Skip to content

fix(android): Improve gen 1 TOTP docs #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 23, 2024
Merged

fix(android): Improve gen 1 TOTP docs #6877

merged 6 commits into from
Sep 23, 2024

Conversation

mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Feb 2, 2024 •
edited
Loading

Description of changes:

  • Add missing docs for Android for MFA selection and TOTP setup in Multi-Step Sign In page.
  • Fix incorrect docs for MFA selection in Manage MFA Settings (was incorrectly showing confirm with TOTP content)
  • Convert Fragment to InlineFilter on affected sections.

Related GitHub issue #, if available:

#6874

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the redirects-needed Redirects need to be created for deleted pages label Feb 2, 2024
@mergify Mergify
Copy link

mergify bot commented Feb 2, 2024

@mattcreaser, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)

  • What is the target address of the redirect? (Where are you trying to redirect to?)

  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

@mattcreaser
Copy link
Member Author

No redirects are needed because I replaced the deleted fragment with an InlineFilter.

@mattcreaser mattcreaser removed the redirects-needed Redirects need to be created for deleted pages label Feb 5, 2024
tjleing
tjleing previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@tjleing tjleing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with a nit, looks good!

@github-actions github-actions bot added the redirects-needed Redirects need to be created for deleted pages label Feb 12, 2024
@mergify Mergify
Copy link

mergify bot commented Feb 12, 2024

@mattcreaser, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)

  • What is the target address of the redirect? (Where are you trying to redirect to?)

  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

@mattcreaser mattcreaser removed the redirects-needed Redirects need to be created for deleted pages label Feb 13, 2024
@mattcreaser mattcreaser requested a review from josefaidt as a code owner May 3, 2024 20:38
@josefaidt josefaidt changed the title fix(android): Improve TOTP docs fix(android): Improve gen 1 TOTP docs Jul 12, 2024
@timngyn timngyn requested a review from hdworld11 as a code owner September 23, 2024 19:59
@github-actions github-actions bot added the redirects-needed Redirects need to be created for deleted pages label Sep 23, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 23, 2024

@mattcreaser, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)

  • What is the target address of the redirect? (Where are you trying to redirect to?)

  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

@timngyn timngyn enabled auto-merge (squash) September 23, 2024 20:08
@timngyn timngyn merged commit 5a4a0fb into main Sep 23, 2024
13 checks passed
@timngyn timngyn deleted the mattcreaser/totp-docs branch September 23, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renebrandel renebrandel Awaiting requested review from renebrandel

@hdworld11 hdworld11 Awaiting requested review from hdworld11 hdworld11 is a code owner

4 more reviewers

@dbanksdesign dbanksdesign dbanksdesign approved these changes

@vincetran vincetran vincetran approved these changes

@josefaidt josefaidt josefaidt approved these changes

@tjleing tjleing tjleing approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
redirects-needed Redirects need to be created for deleted pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattcreaser @dbanksdesign @vincetran @josefaidt @tjleing @timngyn